[Bug 602960] Review Request: maven-eclipse-plugin - Maven Eclipse Plugin

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 14 09:20:12 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602960

Alexander Kurtakov <akurtako at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Alexander Kurtakov <akurtako at redhat.com> 2010-06-14 05:20:08 EDT ---
Review:
OK: rpmlint must be run on every package. Output:
maven-eclipse-plugin.noarch: E: explicit-lib-dependency aqute-bndlib
This is not a lib package.

maven-eclipse-plugin.noarch: W: spelling-error %description -l en_US classpath
-> class path, class-path, classmate
maven-eclipse-plugin.noarch: W: no-documentation
maven-eclipse-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-eclipse-plugin

False positives. 

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. There is no license file. 

Please ask upstream to include one.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8. 

It may be better to do 
# Install necessary package to maven repository
mvn-jpp \
        -e \
        -Dmaven2.jpp.mode=true \
        -Dmaven2.jpp.depmap.file=${MAVEN_DEPMAP} \
        -Dmaven.repo.local=$MAVEN_REPO_LOCAL \
        install:install-file \
        -DgroupId=org.eclipse.core \
        -DartifactId=resources \
        -Dversion=3.5.2-v201004121342 \
        -Dpackaging=jar \
       
-Dfile=/usr/lib/eclipse/plugins/org.eclipse.core.resources_3.5.2.201004121342.jar

in the %prep section.

Otherwise, package looks good.

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list