[Bug 602791] Review Request: xrootd - Extended ROOT file server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602791

--- Comment #2 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2010-06-14 11:03:31 EDT ---
(In reply to comment #1)
> Summary and comments
> 
> 1) The 
> xrootd-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libXrdPosix.so.0.0.0
> _exit at GLIBC_2.2.5
> xrootd-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libXrdClient.so.0.0.0
> exit at GLIBC_2.2.5
> xrootd-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libXrdRootd.so.0.0.0
> _exit at GLIBC_2.2.5
>  can you open a bug upstream.

I have now sent a mail with this issue to xrootd-bugs at slac.stanford.edu, which
is indicated as the preferred way to report bugs in xrootd on
http://xrootd.slac.stanford.edu/Bug_Report.htm - it probably ends up in an
issue tracker somewhere - but I didn't get any reply yet, so I can not give a
reference. This could be due to grey listing.

> 2) Source1: xrootd-manpages.tar.gz
>   Can you ellaberate more on where this tar ball comes from so some one else
> could
>   create it.

Added some comments to the spec file.

> 3) Man pages are LGPL not BSD.

Added LGPLv2+ to the License tag

> 4) Presumably  pthreads-win32 directory can be deleted, it's GPL so to be sure
> it's not being used 
>    delete it.

done

> 5) src/XrdSecssl/libsslGridSite/* is ASL2.0/BSD but also is really just a copy
> of gridsite
>    source code as you know now packaged, can you use the ready packaged one.
>    Looking harder I see this may not actually be used, delete it to be sure.

done

> 6) There is no LICENSE file, can you request upstream adds one.

done - to the same e-mail as above.

> 7) I see you made some comments on the shared library .so and the module .so.
> 
> Something to think about, do you want to library version the shared libs?
> Can the actual modules(or plugins) go in /usr/lib64/xrootd/modules with as
> necessary
> symlinks to the versioned sos in %{_libdir} . All depends on how hard it is to
> do.

The plugin handling in xrootd is not centralized to one place in the code, but
dlopen is called in very many places. I think this would be quite a lot of
work.

> 8) The description of the package is a bit terse, can you add what xrootd can
>    actually be used for.

I have expanded the package description.

> 9) You may want to increase the BR for java to bring in an openjdk rather than
>    just GCJ. My mock build did not build a .jar and only built a .so. 

I can not reproduce this. The jar built fine for me even with java-1.4.2-gcj on
RHEL 4.

>   Steve.    

New version:

Spec URL: http://www.grid.tsl.uu.se/review/xrootd.spec
SRPM URL: http://www.grid.tsl.uu.se/review/xrootd-20100315-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.