[Bug 603269] Review Request: rubygem-plist - All-purpose Property List manipulation library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603269

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-06-14 12:21:10 EDT ---
Created an attachment (id=423896)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=423896)
patch to make rake test succeed

Some notes:

* ruby(abi) dependency
  - ruby module packages must have "R: ruby(abi) = 1.8".
    https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* %prep, %build section:
  - From rpmlint
----------------------------------------------------------------
$ rpmlint -I 'no-%prep-section'
no-%prep-section:
The spec file does not contain a %prep section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality.  Add the section, even if
empty.
----------------------------------------------------------------
    i.e. (in the future) rpmbuild may do some additional needed procedure
    before the contents written in %prep or %build begins.

    So even if currently %prep or %build can be empty, please add them.

* %check
  - Doing "rake test" needs the attached patch.
    ( I guess that (although I have not checked it in detail)
      rdoc/task is in ruby 1.9. On Fedora rdoctask is in rake gem anyway )

* %doc in -doc subpackage
  - I think %doc attribute in -doc subpackage is redundant because
    rpm's name already shows that this is for documentation.

! macros in comments
------------------------------------------------------------------
#export PATH=$PATH:%{buildroot}%{geminstdir}/lib/plist
#export LD_LIBRARY_PATH=$PATH:%{buildroot}%{geminstdir}/lib
....
------------------------------------------------------------------
  - These comment lines include macros and rpmlint warns for these:
------------------------------------------------------------------
rubygem-plist.src:51: W: macro-in-comment %{buildroot}
rubygem-plist.src:51: W: macro-in-comment %{geminstdir}
------------------------------------------------------------------

    The reason rpmlint warns for "macro-in-comment" is that
    during rpmbuild macros are expanded anyway, even in comment lines.
    For this package this is safe, however if a defined macro contains
    several lines, this can cause some strange behavior.
    - For example, with "#%configure", configure script is executed
      against expectation

    So it is always recommended to excape macros in comment lines
    using %% instead of %.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.