[Bug 603521] Review Request: pynetsnmp - Python ctypes bindings for NET-SNMP with Twisted integration

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 14 17:34:53 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603521

Ian Weller <ian at ianweller.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #3 from Ian Weller <ian at ianweller.org> 2010-06-14 13:34:52 EDT ---
[  OK  ] specfiles match:
  b91de570b8543638cbb5509ec3df554e  pynetsnmp.spec
  b91de570b8543638cbb5509ec3df554e  pynetsnmp-0.28.14-1.fc13.src/pynetsnmp.spec
[  OK  ] source files match upstream:
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
  (Is there a more specific link than zenoss.com for pynetsnmp?)
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  N/A ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  N/A ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
  (ignoring spelling warnings)
[FAILED] final provides and requires are sane
  pylint reports that this module depends on Twisted, but the package does not
  require it.
[  N/A ] %check is present and all tests pass:
[  N/A ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  N/A ] desktop files valid and installed properly.

Take a look at the package requires.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list