[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 15 13:09:57 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #27 from Chen Lei <supercyper1 at gmail.com> 2010-06-15 09:09:49 EDT ---
formal review here:
+:ok, =:needs attention, -:needs fixing

MUST Items:
[+] MUST: rpmlint must be run on every package.
libjpeg-turbo.x86_64: W: shared-lib-calls-exit /usr/lib64/libjpeg.so.62.0.0
exit at GLIBC_2.2.5
libjpeg-turbo-devel.x86_64: W: obsolete-not-provided libjpeg-static
libjpeg-turbo-tools.x86_64: W: obsolete-not-provided libjpeg
Those warnings are harmless, and won't fix.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines. [FIXME?: covers this
list and more]
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
<<md5sum checksum>>ac8bb8b00558b077c159a2f35dc196a0
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[=] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
[+] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[=] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.

Issues:
1. BR: nasm should be conditional

%ifarch %{ix86} x86_64
BuildRequires: nasm
%endif


2.

It'll be better to add more files to %doc

%doc README README-turbo.txt change.log ChangeLog.txt LGPL.txt LICENSE.txt 
%file devel
%doc coderules.doc jconfig.doc libjpeg.doc structure.doc wizard.doc example.c
%file tools
usage.doc 

3.

Personally, I suggest you to change -tools subpackage to -utils subpackages for
two reasons:

yum list \*-utils and yum list \*-tools show we have much more utils
subpackages in repo;

Upstream and wikipedia call those programs as utilities, the word utility will
be more appropriate compared to tool.

See http://en.wikipedia.org/wiki/Libjpeg

Utilities
The following utility programs are available with libjpeg:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list