[Bug 592672] Review Request: hct - A HDL complexity tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592672

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Petr Pisar <ppisar at redhat.com> 2010-06-15 10:57:38 EDT ---
$ rpmlint -i hct.spec ../RPMS/noarch/hct-0.7.60-1.fc13.noarch.rpm 
hct.noarch: E: useless-provides perl(HCT::Std::IO)
This package provides 2 times the same capacity. It should only provide it
once.

hct.noarch: W: no-manual-page-for-binary hct.pl
Each executable in standard binary directories should have a man page.

1 packages and 1 specfiles checked; 1 errors, 1 warnings.

The error is because of double package HCT definition:

$ grep -Hnr 'package HCT::Std::IO' lib/
lib/HCT/Std.pm:45:package HCT::Std::IO;
lib/HCT/Std/IO.pm:19:package HCT::Std::IO;
lib/HCT/Std/IO.pm:60:package HCT::Std::IO::Handle;

This is upstream bug. Not fatal for Fedora.

Things that I'd like to see corrected:

* The homepage URL should end with slash.
* Description: Please expand the IC abbreviation to full words `integrated
circuit'. The description should be understandable even for guys who do not
want to install the package.
* The big clean-up with %{__rm} -rf `find . -name 'config*' is dangerous.
(Imagine a file name contained a white space). Use "find -name 'config*' -depth
-exec rm -rf -- '{}' \+" or something like that.
* Why the hct.pl has '.pl' extension? Is it necessary? Original build system
delivers "hct" wrapper (if it worked). What about just "hct" name or symlink to
hct.pl?

The spec file looks good otherwise. Please, show me updated spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.