[Bug 605329] Review Request: gnome-desktop3 - Shared code among gnome-panel, gnome-session, nautilus, etc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605329

Randall Berry <randyn3lrx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |randyn3lrx at gmail.com

--- Comment #1 from Randall Berry <randyn3lrx at gmail.com> 2010-06-17 22:36:01 EDT ---
3 spelling warnings can be safely ignored.

The following warnings must be fixed:

gnome-desktop3.src:95: W: macro-in-comment %{_datadir}
gnome-desktop3.src:96: W: macro-in-comment %{_datadir}
gnome-desktop3.src:101: W: macro-in-comment %{_bindir}
gnome-desktop3.src: W: no-cleaning-of-buildroot %clean
gnome-desktop3.src: W: no-buildroot-tag
gnome-desktop3.src: W: no-%clean-section

Remove or escape macro-in-comment in %files section. (Remove macros or use
%%{_macro} to escape.)

Add as first 2 lines in %install section:

rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT

Add after %install section:

%clean
rm -rf $RPM_BUILD_ROOT

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.