[Bug 605290] Review Request: transmageddon - A video transcoder built using GStreamer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605290

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org

--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2010-06-18 09:38:46 EDT ---
Hmm, I tried to transcode a random movie file into webm and this is the crash:

Traceback (most recent call last):
  File "transmageddon.py", line 676, in on_presetchoice_changed
    self.devicename= self.presetchoices[presetchoice]
KeyError: 'Keine Voreinstellungen'
Traceback (most recent call last):
  File "transmageddon.py", line 624, in on_transcodebutton_clicked
    self._start_transcoding()
  File "transmageddon.py", line 516, in _start_transcoding
    audiocodec, videocodec, self.devicename, 
AttributeError: TransmageddonUI instance has no attribute 'devicename'

When clicking on 'cancel' again:
Traceback (most recent call last):
  File "transmageddon.py", line 636, in on_cancelbutton_clicked
    self._cancel_encoding =
transcoder_engine.Transcoder.Pipeline(self._transcoder,"null")
AttributeError: TransmageddonUI instance has no attribute '_transcoder'


Besides that:
The 'mkdir -p's are not needed, a snipped from rpmbuild output:
test -z "/usr/share/applications" || /bin/mkdir -p
"/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/applications"
 /usr/bin/install -c -m 644 transmageddon.desktop
'/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/applications'
test -z "/usr/share/pixmaps" || /bin/mkdir -p
"/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/pixmaps"
 /usr/bin/install -c -m 644 transmageddon.svg
'/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/pixmaps'
test -z "/usr/share/man/man1" || /bin/mkdir -p
"/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/man/man1"
 /usr/bin/install -c -m 644 transmageddon.1
'/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/man/man1'
test -z "/usr/share/transmageddon" || /bin/mkdir -p
"/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64/usr/share/transmageddon"

That's done by the Makefile itself.


Another warning:
/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64//usr/share/applications/transmageddon.desktop:
warning: key "Encoding" in group "Desktop Entry" is deprecated
/home/tom/rpmbuild/BUILDROOT/transmageddon-0.16-1.fc13.x86_64//usr/share/applications/transmageddon.desktop:
warning: value "GNOME;GTK;Application;AudioVideo;X-Ximian-Main;X-Red-Hat-Base;"
for key "Categories" in group "Desktop Entry" contains a deprecated value
"Application"


- Don't mix RPM_BUILD_ROOT and buildir.
  See
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

- You write %{buildroot}/%{_datadir}: %{_datadir} already contains an '/' at
the beginning.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.