[Bug 597597] Review Request: liblouis - A Braille translator and back-translator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597597

--- Comment #3 from Martin Gieseking <martin.gieseking at uos.de> 2010-06-20 03:05:45 EDT ---
(In reply to comment #2)
> While running rpmlint on the rpms, I get several warnings like this:
> 
>   liblouis-tools.i686: W: unstripped-binary-or-object
>   /usr/bin/lou_debug

I don't get these warnings. The debuginfo is only stripped if the executable
flags of the binary files are set. Maybe you use an uncommon umask that
disables the flags. On my system it's 0002.


Here are some more things you should address:

- rpmlint complains about the mixed use of tabs and spaces. Use either spaces
or tabs for indentation, don't mix them.

- replace rm -f $RPM_BUILD_ROOT/usr/lib/liblouis.la
  with rm -f $RPM_BUILD_ROOT/%{_libdir}/liblouis.la
  otherwise your package doesn't build on 64bit archs because libraries go to
/usr/lib64 there

- I suggest to also use a macro in the preceding line:
  rm -f $RPM_BUILD_ROOT/%{_infodir}/dir

- add AUTHORS, NEWS and ChangeLog as %doc to the base package

- documentation files should go to %{_defaultdocdir}/%{name}-%{version}/ but
the .html and .txt file are placed in %{_defaultdocdir}/%{name}/.
I suggest to remove the doc directory in %install and manually add the files as
%doc to the base package: %doc doc/liblouis.txt doc/liblouis.html

- add file COPYING as %doc to the -tools package

- adapt the %changelog headers according to
  https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
  + add your name
  + fix the release number of the latest entry
  + drop the dist tag .f12
  Example:
  * Thu Jun 17 2010 Lars Bjorndal <lars.bjorndal at broadpark.no> 1.8.0-2

- add an empty line between the changlog entry sets to make them easier to
recognize

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.