[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=594806

--- Comment #10 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-06-21 02:38:47 EDT ---
(In reply to comment #9)
> Shouldn't this be named "jBCrypt" to match the case of the upstream project?
> 

>From packaging guidelines on naming:
While case sensitivity is not a mandatory requirement, case should only be used
where necessary. Keep in mind to respect the wishes of the upstream
maintainers. If they refer to their application as "ORBit", you should use
"ORBit" as the package name, and not "orbit". However, if they do not express
any preference of case, you should default to lowercase naming.


Upstream uses jBCrypt, but I am not sure how much they care about the case. Now
that I think about it I am leaning more towards jBCrypt too, but I would leave
it up to packager.


> Possibly you could run the TestBCrypt in %check section?    

This is definitely a good idea, should have noticed too.


Sebastian? I suppose you don't mind the naming that much...so one more release
number with changed name and test run?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.