[Bug 602279] Review Request: libraw - Library for reading RAW files obtained from digital photo cameras

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602279

--- Comment #4 from Siddhesh Poyarekar <spoyarek at redhat.com> 2010-06-21 09:44:21 EDT ---
(In reply to comment #2)
> Some preliminary comments:
> 
> - rm -rf %{buildroot} in %install is no longer required
> 
> - %clean is not required anymore either

Thanks, I'll make this change.

> - the way you handle the docs is wierd. Typically, these are just included in
>   the file list without installing them in the tree, which makes them show up
>   in %{_docdir} automatically.    

The reason I'm manually copying files over rather than using the %doc is that I
want to build a directory tree under the doc dir to separate the manual files
(*.html, *.png) from the license files. I also intend to include the sample
program source code in the future. 

I referred a document that told me to avoid the %doc directive if I'm going to
install a directory tree under the docdir. Unfortunately I cannot find the
document anymore :(

(In reply to comment #3)
> Refer to the lastest guideline:
> When a package only provides static libraries you can place all the static
> library files in the *-devel subpackage. When doing this you also must have a
> virtual Provide for the *-static package
> 
> http://fedoraproject.org/wiki/PackagingGuidelines#Packaging_Static_Libraries_2    

That is exactly what I have tried to do. The libraw package does not get built
at all since it does not have any files in it, so the only output from the
build is a libraw-devel, which also provides libraw-static. Am I missing
something in it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.