[Bug 606288] Review Request: bfast - Blat-like Fast Accurate Search Tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606288

ELMORABITY Mohamed <pikachu.2014 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |pikachu.2014 at gmail.com
         AssignedTo|nobody at fedoraproject.org    |pikachu.2014 at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from ELMORABITY Mohamed <pikachu.2014 at gmail.com> 2010-06-21 11:13:09 EDT ---
Hi,

I will review your package.

At first sight, the .spec looks quite good. Anyway there are some compilation
issues in 32-bit architecture only:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=2261932
As you can see in the logs, the configure script fails to detect basic glibc
functions and headers (string.h, limits.h, etc), so the compilation cannot be
run correctly. It comes from the fact that the 64-bit flag -m64 is always
enabled, whatever the architecture, when dependencies are detected in
configure; as given in configure.ac:
   extended_CFLAGS="-m64 -D_FILE_OFFSET_BITS=64";
   [...]
   CFLAGS="${default_CFLAGS} ${extended_CFLAGS}";

A (quick) solution could be to remove -m64 from extended_CFLAGS in configure,
like this in your .spec:
   %prep
   %setup -q
   %patch0 -p1
   sed -i '/^extended_CFLAGS=/ s/-m64//' configure

Since RPM_OPT_FLAGS obviously already contains -m64, this change doesn't affect
64-bit builds.

But you must report this issue to the bfast developers. By the way, submit also
your patch about pthread, the missing pthread flags are a serious problem when
building the program on Linux.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.