[Bug 606432] Review Request: ditaa - Diagrams Through Ascii Art

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606432

ELMORABITY Mohamed <pikachu.2014 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |pikachu.2014 at gmail.com
         AssignedTo|nobody at fedoraproject.org    |pikachu.2014 at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from ELMORABITY Mohamed <pikachu.2014 at gmail.com> 2010-06-21 12:13:31 EDT ---
Hi,

I will review your package.

A few remarks :

* According to the Java guidelines:
      https://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires
   you should requires a Java 6 compliant JDK like this:
      BuildRequires:  java-devel >= 1:1.6.0
   instead of explicitely requiring OpenJDK that can maybe change in the
future.
   You shoud do the same with the Requires on java:
      Requires:  java >= 1:1.6.0

* ditaa requires apache-commons-cli, xml-commons-apis and batik. They are set
as Requires in your package (and it's good!), but your wrapper doesn't set them
in the classpath, so it cannot work.
   You should modify your wrapper like this:
   [...]
   MAIN_CLASS=org.stathissideris.ascii2image.core.CommandLineConverter
   BASE_JARS="ditaa commons-cli xml-commons-apis batik"

   set_classpath $BASE_JARS

   run "$@"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.