[Bug 570803] Review Request: crawl - Dungeon Crawl Stone Soup - a rogue-like game of exploration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=570803

Michael Scherer <misc at zarb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc at zarb.org

--- Comment #3 from Michael Scherer <misc at zarb.org> 2010-06-21 19:09:53 EDT ---
That's my first review, so I may have likely forgot some point.

Package build fine on mock on f13 on i386.

Here is rpmlint output :
 $ rpmlint *rpm 
crawl.i686: W: name-repeated-in-summary C Crawl
crawl.i686: W: spelling-error %description -l en_US mystifyingly ->
gratifyingly, terrifyingly, horrifyingly
crawl.i686: W: conffile-without-noreplace-flag /var/games/crawl/saves/scores
crawl.i686: W: conffile-without-noreplace-flag /var/games/crawl/saves/logfile
crawl.i686: E: non-standard-executable-perm /usr/bin/crawl 02755L
crawl.i686: E: non-standard-dir-perm /var/games/crawl 0775L
crawl.i686: E: zero-length /var/games/crawl/saves/scores
crawl.i686: E: non-standard-dir-perm /var/games/crawl/morgue 0775L
crawl.i686: E: non-standard-dir-perm /var/games/crawl/saves 0775L
crawl.i686: E: zero-length /var/games/crawl/saves/logfile
crawl.i686: E: non-standard-dir-perm /var/games/crawl/saves/des 0775L
crawl.src: W: name-repeated-in-summary C Crawl
crawl.src: W: spelling-error %description -l en_US mystifyingly ->
gratifyingly, terrifyingly, horrifyingly
crawl-tiles.i686: W: no-documentation
crawl-tiles.i686: W: dangling-symlink /usr/share/crawl/dat/tiles/VeraMono.ttf
/usr/share/fonts/dejavu/DejaVuSansMono.ttf
crawl-tiles.i686: E: non-standard-executable-perm /usr/bin/crawl-tiles 02755L
crawl-tiles.i686: W: dangling-symlink /usr/share/crawl/dat/tiles/Vera.ttf
/usr/share/fonts/dejavu/DejaVuSans.ttf
crawl-tiles.i686: W: no-manual-page-for-binary crawl-tiles
4 packages and 0 specfiles checked; 8 errors, 10 warnings.

The software do not work after installation :

$ crawl  
Save directory "/var/games/stone-soup//saves/" does not exist and I can't
create it.

It seems the renaming broke it.


If there is a soft link to a font in dejavu-sans-fonts, i guess that rpm should
be required.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.