[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt at gmail.com

--- Comment #1 from Michael Schwendt <mschwendt at gmail.com> 2010-06-22 06:34:01 EDT ---
* The --version arg and program output report 0.06 (r59) which doesn't match
RPM package version. // egg-info even refers to 0.06alpha


* The --help arg and Usage output claim that the  -o DIR  arg is optional, but
when omitting -o DIR, the program crashes:

$ vinetto Thumbs.db 
/usr/bin/vinetto:35: DeprecationWarning: the md5 module is deprecated; use
hashlib instead
  import md5
Traceback (most recent call last):
  File "/usr/bin/vinetto", line 114, in <module>
    tDBfname, outputdir, htmlrep, utf8encoding, symlinks = getargs()
  File "/usr/bin/vinetto", line 77, in getargs
    os.system("mkdir " + opts.outputdir + "/" + NUMBERED_THUMBS_DIR)
TypeError: cannot concatenate 'str' and 'NoneType' objects


* Something else is wrong with the -o DIR arg, too. If the target directory
doesn't exist, vinetto creates only half of the target dirs and then fails.
os.system("mkdir",...) is insufficient, and it should either bail out sooner or
use os.makedirs(...) properly.


* For such a small program with no manual, no examples in the README, and a
warning that only one type of Thumbs.db files is understood, I think the
software isn't ready yet.

| SHOULD: The reviewer should test that the package functions as
| described. A package should not segfault instead of running,
| for example.


* The good news: The packaging is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.