[Bug 508351] Review Request: josm - java openstreetmap editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351

--- Comment #65 from Alex Lancaster <alexl at users.sourceforge.net> 2010-06-22 13:16:18 EDT ---
(In reply to comment #64)
> (In reply to comment #62)
> > Just for curiosity, do you know why the JAR installed (6 MB) is 150% bigger
> > than the one generated by the authors (4 MB)?
> Because this package is not valid, accorded to the guidelines. It embeds
> dependencies, whereas it is forbidden:
>   
> https://fedoraproject.org/wiki/Packaging/Java#Pre-built_JAR_files_.2F_Other_bundled_software

That shouldn't be the case according to the review in comment #49, it claims: 

"+ The package does NOT bundle copies of system libraries."

It appears that the reviewer may have missed that jars were still being
bundled, even though it seems that from comment #2 some bundled jars were
identified and (apparently) removed around comment #4, but some may have been
added since.  

> 4) add ant and metadata-extractor as Requires.    

Actually the installation pulls in the metadata-extractor as a separate package
so the "Requires" appear OK, it's just that  the .class files for that package
are duplicated inside josm.jar, so apparently the packager didn't remove them
properly from the created josm.jar

This needs to be fixed before this bug is closed as it appears the package
passed review prematurely.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.