[Bug 607075] Review Request: perl-Test-utf8 - Handy utf8 tests

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607075

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-06-23 06:14:33 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2266844
+ rpmlint output for SRPM and for RPM.
perl-Test-utf8.noarch: W: spelling-error Summary(en_US) utf -> fut, Ute, Utah
perl-Test-utf8.noarch: W: spelling-error %description -l en_US utf -> fut, Ute,
Utah
perl-Test-utf8.src: W: spelling-error Summary(en_US) utf -> fut, Ute, Utah
perl-Test-utf8.src: W: spelling-error %description -l en_US utf -> fut, Ute,
Utah
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ source files match upstream url (sha1sum)
60858677fd42148e21682724178a5b6a24a48991  Test-utf8-0.02.tar.gz
60858677fd42148e21682724178a5b6a24a48991  Test-utf8-0.02.tar.gz.srpm
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=39,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.22 cusr  0.06
csys =  0.32 CPU)
+ Package perl-Test-utf8-0.02-1.fc14.noarch =>
Provides: perl(Test::utf8) = 0.02
Requires: perl >= 0:5.007003 perl(charnames) perl(Encode) perl(Exporter)
perl(strict) perl(Test::Builder) perl(vars) perl(warnings)
rpmlib(VersionedDependencies) <= 3.0.3-1
+ Not a GUI application

Suggestions:
1) looks yum already take care 
Requires:       perl(Test::Builder) >= 0.15
so you can drop it.

2) I think Changelog should include packager email id also.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.