[Bug 607078] Review Request: perl-File-Type-WebImages - Determine web image file types using magic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607078

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-06-23 06:14:21 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2266865
+ rpmlint output for SRPM and for RPM.
perl-File-Type-WebImages.noarch: W: spelling-error %description -l en_US
filename -> file name, file-name, filament
perl-File-Type-WebImages.src: W: spelling-error %description -l en_US filename
-> file name, file-name, filament
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ source files match upstream url (sha1sum)
6ad8671092618446305ce86d9ef9ba91f5b6c15e  File-Type-WebImages-1.01.tar.gz
6ad8671092618446305ce86d9ef9ba91f5b6c15e  File-Type-WebImages-1.01.tar.gz.srpm

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=15,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.07 cusr  0.02
csys =  0.12 CPU)

+ Package perl-File-Type-WebImages-1.01-1.fc14.noarch=>
Provides: perl(File::Type::WebImages) = 1.01
Requires: perl(base) perl(IO::File) perl(strict) perl(vars) perl(warnings)
rpmlib(VersionedDependencies) <= 3.0.3-1
+ Not a GUI application

Suggestions:
1) I think Changelog should include packager email id also.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.