[Bug 607224] Review Request: eclipse-fedorapackager - Eclipse plug-in which helps to interact with Fedora infrastructure

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 23 18:51:44 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607224

--- Comment #4 from Severin Gehwolf <sgehwolf at redhat.com> 2010-06-23 14:51:43 EDT ---
> FIXIT: The sources used to build the package must match the upstream source, as
> provided in the spec URL. There are both download instructions and fetch shell
> script please clarify which one is used and remove the other.

I've updated the spec file to include the command sequence as to how the source
tarball has been produced. It's a tarball containing revision
7131f3988117c916c04602a78928c7aee5213900 of
git://git.fedorahosted.org/eclipse-fedorapackager.git. Generation of the
tarball should be reproducible now.

Other source references have been removed.

> Other comments:
> * please remove the -v -D parameters from the pdebuild call, they are not
> really needed and make the output so unreadable

Fixed. Totally forgot about removing those.

For reference
SPEC:
http://www.cs.toronto.edu/~sgehwolf/fedora/rpm-work/eclipse-fedorapackager.spec 
SRPM:
http://www.cs.toronto.edu/~sgehwolf/fedora/rpm-work/eclipse-fedorapackager-0.0.3-1.fc13.src.rpm

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list