[Bug 606759] Review Request: nvi - 4.4BSD re-implementation of vi

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606759

Michel Alexandre Salim <michael.silvanus at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Michel Alexandre Salim <michael.silvanus at gmail.com> 2010-06-24 06:30:53 EDT ---
APPROVED -- the remaining items are all cosmetic in nature.

(In reply to comment #3)
> (In reply to comment #2)
> > Using the stand-alone spec, as it uses better filesystem macros
> 
> yes, sorry for not upgrading src.rpm
> 
> > #+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n)
> 
> Do you have some app for doing this?

Org-Mode for Emacs: http://orgmode.org/

> 
> > ** TODO rpmlint [0/2]
> > *** FAIL on src.rpm
> >     - State "FAIL"       from ""           [2010-06-23 Wed 21:04] \\
> >       nvi.src:81: W: macro-in-comment %patch27
This is fixed.

> >       (when commenting out, I normally just replace % with # to avoid this)
> >       nvi.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 4)
Still there, but not really a bug (it's the Summary line)


> >       nvi.src: W: patch-not-applied Patch27: nvi-28-regex_widechar.patch
Still there too, but I take it this patch might be needed later.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.