[Bug 603633] Review Request: scholarsfonts-cardo-fonts - This is designed for classicists, Biblical scholars, medievalists, linguists

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603633

--- Comment #1 from Pravin Satpute <psatpute at redhat.com> 2010-06-25 00:14:50 EDT ---
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2269813
+ rpmlint is silent for SRPM and for RPM.
*  scholarsfonts-cardo-fonts.src: W: no-buildroot-tag
now buildroot is not required, so this is ok

*scholarsfonts-cardo-fonts.noarch: W: obsolete-not-provided cardo-fonts
  since cardo-fonts built only for devel version and for very short life span,
provide is not required really.

+ source files match upstream url
82bca1b561f5a84c676d27dd4e0280a1  cardo99.zip
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.

+ license is open source-compatible.
in Manual98a.pdf page 14 it is written 

"This font is free for personal, non-commercial, or non-profit use. It may also
be used to
prepare camera-ready copy for papers that will appear in academic journals,
even if the
author of the paper receives remuneration for article. Any other commercial use
(includ-
ing the printing of books to be sold at a profit) requires the purchase of an
appropriate li-
cense. Individuals may give copies to others, as long as all files from the
original zip ar-
chive are kept together and none is altered. This software may not be posted on
any web
page, included in any compilation, or sold in any form without the express
permission of
David J. Perry. Those who wish to promote the use of this font are encouraged
to put a
link to my home page http://scholarsfonts.net on their web sites so that others
may
download it."

It is conflicting with the mentioned license OFL in the font file.  On
http://scholarsfonts.net/ It is written that from .99 version cardo-fonts are
released under OFL

Manual98a.pdf is written for old version of cardo-fonts, so i think better to
drop it. Or good to ask upstream to update it for the license change. 


- License text is included in package.
good to ask upstream to include license text in package, since license in ttf
file is not visible vi all application.
will be good if you can add License as source1 in this package

+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content. // ask this
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.