[Bug 607777] Review Request: xnoise - Tracklist-centric Media Player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607777

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mschwendt at gmail.com
         AssignedTo|nobody at fedoraproject.org    |mschwendt at gmail.com

--- Comment #3 from Michael Schwendt <mschwendt at gmail.com> 2010-06-25 06:33:17 EDT ---
> SRPM URL:

http://salimma.fedorapeople.org/specs/gnome/xnoise-0.1.6-1.fc13.src.rpm


$ sha1sum xnoise-0.1.6.tar.gz 
224d328f928f7aa016309df9d307cd42da71f026  xnoise-0.1.6.tar.gz


> %{_datadir}/vala/vapi/xnoise-1.0.*

Nothing pulls in vala when installing xnoise-devel, but vala is the package
that owns the vala/vapi directories. You either need to include these
directories with the same permissions as in "vala" or require "vala":
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

Precedent for "multiple ownership of vala dirs": libcanberra-devel -> bug
523473


* rpmlint:

xnoise.x86_64: E: incorrect-locale-subdir
/usr/share/locale/default/LC_MESSAGES/xnoise.mo

Indeed looks like a file you ought to delete or %exclude.


* Should xnoise play _all_ files understood by GStreamer? For example, with
gstreamer-plugins-ugly installed, it plays .sid files (MIME type
audio/prs.sid). But with gstreamer-plugins-fc installed, it doesn't recognize
.fc files (which are played by rhythmbox, on the contrary).


* Translations are far from complete. The de_DE translation module is mostly
useless.


* Other than that, the packaging is fine, and the app works.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.