[Bug 607778] Review Request: xnoise-plugins-core - Core plugins for xnoise

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607778

--- Comment #3 from Michael Schwendt <mschwendt at gmail.com> 2010-06-26 16:17:05 EDT ---
$ sha1sum xnoise-plugins-core-0.1.6.tar.gz 
8eb208d9d3cc263e36904216d17520bc00b89a67  xnoise-plugins-core-0.1.6.tar.gz


* "BuildRequires: intltool" is missing


* MediaWatcher plugin crashes:
  1) start xnoise
  2) open Preferences > Plugins
  3) enable MediaWatcher
  4) disable MediaWatcher
  5) enable MediaWatcher
  6) GLib-GObject warnings on stderr + segfault


* LastfmCovers plugin crashes on exit:
  1) start xnoise
  2) enable LastfmCovers plugin
  3) quit
  4) segfault


* Notifications plugin prints "<b> ... </b>"


* /usr/lib64/xnoise/*.la files are not needed


* xnoise-plugins-core.x86_64: E: incorrect-locale-subdir
/usr/share/locale/default/LC_MESSAGES/xnoise-plugins-core.mo


* %{_libdir}/xnoise ownership : currently owned by the -plugins-core package,
which is optional, however. Would separate xnoise plugin packages need to own
%{_libdir}/xnoise  or do you think it would be better to make the base "xnoise"
package own that directory?


* xnoise-plugins-core-devel : What's the purpose of this package? The current
%description can't be correct. ;-)


* Rest is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.