[Bug 595638] Review Request: qwit - Lightweight desktop client for Twitter microblogging service

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 28 08:23:47 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595638

--- Comment #5 from Kalev Lember <kalev at smartlink.ee> 2010-06-28 04:23:46 EDT ---
If you are interested, we could try to fix the CMakeLists.txt together. But it
only makes sense if you are willing to push those changes upstream; if not,
it's probably easier to keep using qmake.


I took a quick look at the CMakeLists.txt file and it looks like we need to do
the following changes:
-       /usr/include/qca2/QtCrypto
+       /usr/include/QtCrypto

However, changing include directory like that is just a quick hack to get it
building and it's not a proper fix to send upstream. Proper fix would be to
create a directory cmake_modules/ in qwit source tree and copy
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/cmake/modules/FindQCA2.cmake
over there. Then we can do something like this:
# Custom cmake modules
set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake_modules")
find_package(QCA2 REQUIRED)

When this is done, we can use ${QCA2_INCLUDE_DIR} instead of
/usr/include/qca2/QtCrypto in the include_directories() call:

-       /usr/include/qca2/QtCrypto
+       ${QCA2_INCLUDE_DIR}


The following two changes should be easily upstreamable:

-install( TARGETS qwit DESTINATION ${QT_BINARY_DIR} )
+install( TARGETS qwit DESTINATION bin )

-install( FILES images/qwit.png DESTINATION share/icons )
+install( FILES images/qwit.png DESTINATION share/icons/hicolor/32x32/apps )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list