[Bug 595638] Review Request: qwit- Qt4 cross-platform client for Twitter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595638

--- Comment #7 from Chen Lei <supercyper1 at gmail.com> 2010-06-28 04:35:46 EDT ---
(In reply to comment #5)
> If you are interested, we could try to fix the CMakeLists.txt together. But it
> only makes sense if you are willing to push those changes upstream; if not,
> it's probably easier to keep using qmake.
> 
> 
> I took a quick look at the CMakeLists.txt file and it looks like we need to do
> the following changes:
> -       /usr/include/qca2/QtCrypto
> +       /usr/include/QtCrypto
> 
> However, changing include directory like that is just a quick hack to get it
> building and it's not a proper fix to send upstream. Proper fix would be to
> create a directory cmake_modules/ in qwit source tree and copy
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/cmake/modules/FindQCA2.cmake
> over there. Then we can do something like this:
> # Custom cmake modules
> set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake_modules")
> find_package(QCA2 REQUIRED)
> 
> When this is done, we can use ${QCA2_INCLUDE_DIR} instead of
> /usr/include/qca2/QtCrypto in the include_directories() call:
> 
> -       /usr/include/qca2/QtCrypto
> +       ${QCA2_INCLUDE_DIR}
> 
> 
> The following two changes should be easily upstreamable:
> 
> -install( TARGETS qwit DESTINATION ${QT_BINARY_DIR} )
> +install( TARGETS qwit DESTINATION bin )
> 
> -install( FILES images/qwit.png DESTINATION share/icons )
> +install( FILES images/qwit.png DESTINATION share/icons/hicolor/32x32/apps )  

Yesterday, I fixed those issues locally and write a new spec, but since qwit is
a quite small package, so I finally decided to continue use qmake. Also, the
default building way for qwit is qmake, See INSTALL in the tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.