[Bug 527306] Review Request: jericho-html - Jericho HTML Parser

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 28 09:09:58 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527306

--- Comment #7 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-06-28 05:09:55 EDT ---
Ok, I am sorry for this, but I made a mistake when telling you to change group
to "Development/Documentation" it was supposed to be just "Documentation" (I
had to correct that exact problem so many times I remembered it as correct
solution). It is supposed to be just "Documentation". Also there is no group
"Development/Libraries/Java". Please look into /usr/share/doc/rpm-X.Y.Z/GROUPS
and pick one from there.

> - Don't need to copy library for tests  

You removed copying of jar file not for testing but for samples, and I believe
that sample will now stop working. Your change was:

61d61
< cp dist/%{name}-%{version}.jar samples/webapps/JerichoHTML/WEB-INF/lib

Now the JerichoHTML.war is missing jericho dependency. Why not just create
symlink of jericho jar file into samples/webapps/JerichoHTML/WEB-INF/lib and
install that without even creating the war file. I don't see any reason why we
should have both the war and the unpacked version.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list