[Bug 609350] Review Request: perl-Catalyst-View-Component-SubInclude - Use subincludes in your Catalyst views

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609350

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-06-30 00:44:07 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2282084
+ rpmlint outputfor SRPM and for RPM 
perl-Catalyst-View-Component-SubInclude.noarch: W: spelling-error
Summary(en_US) subincludes -> sub includes, sub-includes, includes
perl-Catalyst-View-Component-SubInclude.src: W: spelling-error Summary(en_US)
subincludes -> sub includes, sub-includes, includes
==> this can be Ignored.
+ source files match upstream url (sha1sum)
fc0fd434b2296d4a92ab2a3385d28a9d901eb029 
Catalyst-View-Component-SubInclude-0.09.tar.gz
fc0fd434b2296d4a92ab2a3385d28a9d901eb029 
Catalyst-View-Component-SubInclude-0.09.tar.gz.srpm
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=5,  1 wallclock secs ( 0.01 usr  0.01 sys +  1.14 cusr  0.09
csys =  1.25 CPU)
+ Package perl-Catalyst-View-Component-SubInclude-0.09-1.fc14.noarch =>
Provides: perl(Catalyst::View::Component::SubInclude) = 0.09
perl(Catalyst::View::Component::SubInclude::ESI) = 0.07
perl(Catalyst::View::Component::SubInclude::SSI) = 0.09
perl(Catalyst::View::Component::SubInclude::SubRequest) = 0.07
perl(Catalyst::View::Component::SubInclude::Visit) = 0.07
Requires: perl(Carp) perl(Catalyst::Utils) perl(Class::MOP) perl(Moose)
perl(Moose::Role) perl(MooseX::Types::Moose) perl(namespace::clean)
rpmlib(VersionedDependencies) <= 3.0.3-1
+ Not a GUI application

Suggestions:
1) you don't need following in spec as yum will resolve it automatically 
Requires:       perl(Catalyst::Plugin::SubRequest)
Requires:       perl(Catalyst::Runtime) >= 5.80014
Requires:       perl(Moose)
Requires:       perl(Moose::Role)
Requires:       perl(MooseX::Types)
Requires:       perl(namespace::clean)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.