[Bug 605373] Review Request: qgis - A user friendly Open Source Geographic Information System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605373

--- Comment #5 from Kevin Kofler <kevin at tigcc.ticalc.org> 2010-06-30 18:12:16 EDT ---
rpmlint output:

qgis.i686: W: spelling-error %description -l en_US geotiff -> geotaxis,
geotropism, geothermic
qgis.i686: W: spelling-error %description -l en_US plugins -> plug ins,
plug-ins, plugging
qgis.i686: W: obsolete-not-provided qgis-theme-classic
qgis.i686: W: obsolete-not-provided qgis-theme-gis
qgis.i686: W: obsolete-not-provided qgis-theme-nkids
qgis.i686: W: shared-lib-calls-exit /usr/lib/libqgis_core.so.1.4.0
exit at GLIBC_2.0
qgis.src: W: spelling-error %description -l en_US geotiff -> geotaxis,
geotropism, geothermic
qgis.src: W: spelling-error %description -l en_US plugins -> plug ins,
plug-ins, plugging
qgis.src:233: W: macro-in-%changelog %description
qgis.src:233: W: macro-in-%changelog %package
qgis.src: W: no-buildroot-tag
qgis.x86_64: W: spelling-error %description -l en_US geotiff -> geotaxis,
geotropism, geothermic
qgis.x86_64: W: spelling-error %description -l en_US plugins -> plug ins,
plug-ins, plugging
qgis.x86_64: W: obsolete-not-provided qgis-theme-classic
qgis.x86_64: W: obsolete-not-provided qgis-theme-gis
qgis.x86_64: W: obsolete-not-provided qgis-theme-nkids
qgis.x86_64: W: shared-lib-calls-exit /usr/lib64/libqgis_core.so.1.4.0
exit at GLIBC_2.2.5

* The "spelling-error" warnings are obviously bogus.
* shared-lib-calls-exit is an upstream issue, definitely not relevant for a
rereview, but it should be brought to upstream's attention (it's a bad idea to
call exit in a library).
* The obsolete-not-provided warnings are harmless. You could in principle add
Provides for the themes which are there now (qgis-theme-classic, qgis-theme-gis
and qgis-theme-default), but IMHO that's not needed, because nobody is going to
try to yum install a qgis theme if qgis already ships it and no other package
is ever going to Require a qgis theme.
* no-buildroot-tag is not an issue for a Fedora (as opposed to EPEL) package.

So the rpmlint test passes, I'm going through the remainder of the review
checklist next.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.