[Bug 569582] Review Request: udev-browse - Udev browser tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569582

Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kalev at smartlink.ee

--- Comment #1 from Kalev Lember <kalev at smartlink.ee> 2010-03-01 15:23:35 EST ---
I'm not going to do a thorough review, but I have a comment.

rpmlint complains:
udev-browse-debuginfo.i686: E: debuginfo-without-sources

The reason why this happens is that $RPM_OPT_FLAGS aren't passed to the C
compiler. Also, valac is run in a non-verbose mode, so it's not possible to
inspect compiler flags by looking at the build logs.

Right now the simplistic Makefile just runs valac, which in turn generates C
code and runs C compiler. Valac, however, seems to completely ignore CFLAGS. I
don't have any experience with vala, but I think this problem could be solved
by using valac only to generate C code, and later running the C compiler
directly. That way it's certainly possible to pass CFLAGS to the compiler.

I would suggest to contact upstream maintainer and discuss this issue with him.
It might be possible that he's willing to switch to autotools or cmake, both of
which AFAIK can be used to build vala code.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.