[Bug 569665] Review Request: perl-Color-Calc - Simple calculations with RGB colors

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 2 16:58:22 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569665

--- Comment #2 from Chris Weyl <cweyl at alumni.drew.edu> 2010-03-02 11:58:19 EST ---
Please include the "LICENSE" file in %doc; aside from that, looks good as
usual :)

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2025648

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
0d3bf895e8eae757385317b624bb820e90471376 Color-Calc-1.061.tar.gz
0d3bf895e8eae757385317b624bb820e90471376 Color-Calc-1.061.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Color-Calc-1.061-1.fc13.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Color-Calc-1.061-1.fc13.noarch.rpm
perl(Color::Calc) = 1.061
perl-Color-Calc = 1.061-1.fc13
perl(Color::Calc::WWW) = 1.060
====> requires for perl-Color-Calc-1.061-1.fc13.noarch.rpm
perl(attributes)  
perl(Carp)  
perl(Exporter)  
perl(Graphics::ColorNames)  
perl(Graphics::ColorNames::HTML)  
perl(List::Util)  
perl(:MODULE_COMPAT_5.10.1)  
perl(Params::Validate)  
perl(POSIX)  
perl(Scalar::Util)  
perl(strict)  
perl(utf8)  
perl(warnings)  

=====> perl-Color-Calc-1.061-1.fc13.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Color-Calc-1.061-1.fc13.src.rpm
====> requires for perl-Color-Calc-1.061-1.fc13.src.rpm
perl(ExtUtils::MakeMaker)  
perl(Graphics::ColorNames)  
perl(Graphics::ColorNames::WWW)  
perl(Params::Validate)  
perl(Test::More)  
perl(Test::NoWarnings)  
perl(Test::Pod)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list