[Bug 569955] Review Request: python-qmf - Python QMF library for Apache Qpid

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569955

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org

--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2010-03-03 06:02:36 EST ---
Just a few comments for now:

- %global and not %define
 
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

- please move python_sitelib + version to the top (in any other specs I saw,
there are on the top. So part of a 'unwritten convention'.

- BR/R on python is unneeded. BR on python-devel adds anything else.

- version naming wrong:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease

It should be something like 0.7-0.1.$DATEsvn
-> It's a prerelease of 0.7 checked out of svn on $DATE.

Example from link above:
kismet-0-0.1.20040110svn (this is a pre-release, svn checkout of kismet)
kismet-0-0.2.20040110svn (this is a bugfix to the previous package)
kismet-0-0.3.20040204svn (this is a new svn checkout, note the increment of
%{X})
kismet-1.0-1 (this is the formal release of kismet 1.0)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.