[Bug 567937] Review Request: mpir - A library for arbitrary precision arithmetic

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 4 02:00:28 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567937

Chen Lei <supercyper at 163.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |supercyper at 163.com

--- Comment #3 from Chen Lei <supercyper at 163.com> 2010-03-03 21:00:27 EST ---
The spec file seems fine.
Only one problem:
# Convert AUTHORS file to UTF-8
iconv --from=ISO-8859-1 --to=UTF-8 AUTHORS -o AUTHORS.conv
mv -f AUTHORS.conv AUTHORS

This will invoke multilib conflict because of timestamp.



Also, why you use perl instead of sed which was included in the fedora minimum
build environment.

perl -pi -e
's|hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=\"-L\\\$libdir\"|g;'
libtool
->
%configure
sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list