[Bug 532521] Review request: trove4j - High performance collections for Java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532521

--- Comment #11 from Guido Grazioli <guido.grazioli at gmail.com> 2010-03-05 14:36:39 EST ---
NEEDSWORK - The package MUST successfully compile and build
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2033734

The build failed during junit tests. Please find the cause of the problem, and
eventually skip junit tests in case it can be ignored.

OK - rpmlint output:
1 packages and 1 specfiles checked; 0 errors, 4 warnings.
trove4j.src: W: spelling-error %description -l en_US util -> til, until, u til
trove4j.src: W: spelling-error %description -l en_US pluggable -> plug gable,
plug-gable, plugged
trove4j.src: W: spelling-error %description -l en_US lang -> Lang, lag, slang
- Can ignore those.
trove4j.src:139: W: libdir-macro-in-noarch-package (main package)
%attr(-,root,root) %{_libdir}/gcj/%{name}
- This one too (its inside %if %{with_gcj} conditional)
OK - The package must be named according to the Package Naming Guidelines
(discussion about naming in bug 504891).
OK - The spec file name must match the base package %{name}
OK - The package must meet the Packaging Guidelines (Java: good - GCJ: good)
OK - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
OK - The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines (license is LGPLv2+ and MIT)
OK - Every binary RPM package which stores shared library files must
call ldconfig in %post and %postun 
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible.
OK - The sources used to build the package must match the upstream source, as
provided in the spec URL. 
09375a0b74eb8560270331239d2f94c3  trove-2.1.0.tar.gz
NA - The spec file MUST handle locales properly 
NA - package not relocatable
OK - A package must own all directories that it creates
OK - A Fedora package must not list a file more than once in the spec file's
%files listings
OK - Permissions on files must be set properly
OK - Each package must have a %clean section
OK - Each package must consistently use macros
NA - The package must contain code, or permissable content (no content)
OK - Large documentation files must go in a -doc subpackage (-javadoc package)
OK - If a package includes something as %doc, it must not affect the runtime of
the application
NA - Header files must be in a -devel package
NA - Static libraries must be in a -static package (no static package)
NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
OK - Packages must NOT contain any .la libtool archives
NA - Packages containing GUI applications MUST include a .desktop file 
OK - No file conflicts with other packages and no general names.
OK - At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK - All filenames in rpm packages must be valid UTF-8
OK - The package does not yet exist in Fedora. The Review Request is not a
duplicate.
OK - %{?dist} tag is used in release    

ADDITIONAL NOTE:

Looking at Java Guidelines, it seems that specifying Require: java version is
mandatory, while it is optional for BuildRequires.
BuildRequires: java-devel [>= specific_version] 
BuildRequires:  jpackage-utils
Requires:  java >= specific_version
Requires:  jpackage-utils

I think its safe for this package, so ill leave up to you whether to fix it or
not.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.