[Bug 568833] Review Request: OpenLP - Church projection software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=568833

Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |NEW
                 CC|                            |cwickert at fedoraproject.org

--- Comment #10 from Christoph Wickert <cwickert at fedoraproject.org> 2010-03-06 13:08:19 EST ---
Thanks for your submission. Some more comments from a quick look over your
spec:

- Please don't use %define for name version and release. Using defines only
makes sense for things that apprear several times in the spec. And if you
really need something like this, use %global, see 
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

- Version and release tags are wrong, see
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages

- Summary should not end with a dot.

- License tag is invalid. "GNU General Public License" is abbreviated as "GPL",
but you need to specify what version of the GPL it is.

- The group "Development/Libraries" is wrong, pick a better one from
/usr/share/doc/rpm-*/GROUPS

- buildroot should be one of these:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- %description should have linebreaks at 80 charakters, otherwise it's hard to
read on a terminal.

- Drop the prefix tag, this is set automatically by the %configure macro. Use
'rpm --eval %configure' to see what the macro does.

- Drop the vendor tag, it is added by the buildsystem. BTW: The vendor is
Fedora, not the upstream developer.

- "Url" should be "URL".

- Don't use "--record=INSTALLED_FILES". list them manually in the spec please.

- Each changelog needs version and release. For a list of allowed formats, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

- I bet you miss some BuildRequires, use mock to check. See
http://fedoraproject.org/wiki/Using_Mock_to_test_package_builds

- Please take a look at https://fedoraproject.org/wiki/Packaging:Python for
python specific hints.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.