[Bug 566406] Review Request: packETH - A GUI packet generator tool

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 7 08:54:37 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566406

--- Comment #8 from Nikolay Ulyanitsky <lystor at lystor.org.ua> 2010-03-07 03:54:35 EST ---
> License tag should still be GPLv2+
Fixed

> Use macros correctly. /usr/bin should be %{__bindir}
There is a problem with %{__bindir}. It is not defined in Fedora 11, 12, 13 and
is not described in the Fedora Wiki.


Spec diff:
 Name:           packETH
 Version:        1.6.5
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        A GUI packet generator tool

 Group:          Applications/Internet
-License:        GPLv3
+License:        GPLv2+
 URL:            http://sourceforge.net/projects/packeth/
 Source0:       
http://downloads.sourceforge.net/packeth/%{name}-%{version}.tar.bz
 Source1:        packETH.desktop
@@ -33,7 +33,7 @@

 %install
 %{__rm} -rf %{buildroot}
-%{__make} DESTDIR=%{buildroot} INSTALL='/usr/bin/install -p' install 
+%{__make} DESTDIR=%{buildroot} INSTALL="%{_bindir}/install -p" install 

 # Install desktop file
 %{__install} -d %{buildroot}%{_datadir}/applications
@@ -55,6 +55,9 @@


 %changelog
+* Sun Mar 07 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.6.5-3
+- Fixed the license tag
+


Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/packETH.spec 
SRPM URL:
http://repo.lystor.org.ua/fedora/12/SRPMS/packETH-1.6.5-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list