[Bug 566407] Review Request: perl-Number-Bytes-Human - Convert byte count to human readable format

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 7 14:59:26 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566407

--- Comment #8 from Nikolay Ulyanitsky <lystor at lystor.org.ua> 2010-03-07 09:59:23 EST ---
> So in summary, just the INSTALLDIR comment and the use of the word "formatter" which is not a word.
Fixed

> Also the "non-coherent-filename" just confuses me
I can't reproduce the error with rpmlint-0.94-1.fc12.noarch


Spec diff:
@@ -1,6 +1,6 @@
 Name:           perl-Number-Bytes-Human
 Version:        0.07
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Convert byte count to human readable format

 Group:          Development/Libraries
@@ -19,7 +19,7 @@


 %description
-This module provides a formatter which turns byte counts to usual readable
+This module is designed to format byte counts to usual readable
 format, like '2.0K', '3.1G', '100B'. It was inspired in the -h option of
 Unix utilities like du, df and ls for "human-readable" output.

@@ -29,19 +29,20 @@

 # Fix file end-of-line encoding
 for f in Changes README; do
-    %{__sed} -i 's/\r//' $f
+    %{__sed} 's/\r//' $f > $f.new
+    touch -r $f $f.new
+    %{__mv} -f $f.new $f
 done


 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
-make %{?_smp_mflags}
+%{__make} %{?_smp_mflags}


 %install
 %{__rm} -rf %{buildroot}
-
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
+%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}

 find %{buildroot} -type f -name .packlist -exec rm -f {} \;
 find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
@@ -65,5 +66,9 @@


 %changelog
+* Sat Feb 13 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 0.07-2
+- Fixed the description
+- Preserve timestamps on documentation files


$ rpmlint perl-Number-Bytes-Human-0.07-2.fc12.src.rpm
perl-Number-Bytes-Human.src: W: spelling-error %description -l en_US du -> dew,
doe, Du
perl-Number-Bytes-Human.src: W: spelling-error %description -l en_US df -> sf,
ff, dd
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


$ rpmlint perl-Number-Bytes-Human-0.07-2.fc12.noarch.rpm
perl-Number-Bytes-Human.noarch: W: spelling-error %description -l en_US du ->
dew, doe, Du
perl-Number-Bytes-Human.noarch: W: spelling-error %description -l en_US df ->
sf, ff, dd
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


Spec URL:
http://repo.lystor.org.ua/fedora/12/SPECS/perl-Number-Bytes-Human.spec

SRPM URL:
http://repo.lystor.org.ua/fedora/12/SRPMS/perl-Number-Bytes-Human-0.07-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list