[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567053

--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-03-07 13:15:42 EST ---
For 0.4:

* build process
  - From build.log:
-------------------------------------------------------------------------
    36  Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.yQ4cHw
    43  + make -j8
    54  cc -o uzbl-core  callbacks.o  events.o  inspector.o  uzbl-core.o
-pthread -lwebkit-1.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0
-lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig
-lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0
-lX11   -pthread 
    56  Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.axM2dB
    69  + make
DESTDIR=/builddir/build/BUILDROOT/uzbl-0-0.4.20100221gitabbffe5c3.i386
PREFIX=/usr install
    76  cc -o uzbl-core  callbacks.o  events.o  inspector.o  uzbl-core.o
-pthread -lwebkit-1.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0
-lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig
-lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0
-lX11   -pthread 
-------------------------------------------------------------------------
    So actually uzbl is compiled twice, once in %build and once
    in %install. It seems that Makefile does not check if the needed
    binaries are already rebuilt or not.
    So either
    - fix Makefile to prevent duplicate compilation
    - or just call "make" once (in %install, as binaries need to be installed
      anyway)

* Desktop file
  - Installed desktop file contains:
-------------------------------------------------------------------------
     5  Exec=uzbl
     6  Icon=uzbl
-------------------------------------------------------------------------
    However none of these are installed.

* "Example" files
  - Well, now I tried "uzbl-browser", and it complains:
-------------------------------------------------------------------------
$ env LANG=C uzbl-browser ; echo $?
cp: cannot stat `/usr/share/uzbl/examples/config/config': No such file or
directory
Could not copy default config to /home/tasaka1/.config/uzbl/config
3
-------------------------------------------------------------------------
   I think the directory name "examples" is really confusing if
   this directory is actually needed on runtime, however it seems that
   this directory cannot be moved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.