[Bug 569893] Review Request: - perl-Net-STOMP-Client - STOMP object oriented client module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569893

Nikolay Ulyanitsky <lystor at lystor.org.ua> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lystor at lystor.org.ua

--- Comment #1 from Nikolay Ulyanitsky <lystor at lystor.org.ua> 2010-03-07 15:06:15 EST ---
==== MUST ITEMS ====
OK: rpmlint must be run on every package. The output should be posted in the
review.

    $ rpmlint {RPMS/noarch,SRPMS}/perl-Net-STOMP-Client-*
    2 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK: The package must be named according to the Package Naming Guidelines .

OK: The spec file name must match the base package %{name}, in the format
    %{name}.spec unless your package has an exemption. [2] .

OK: The package must meet the Packaging Guidelines .

OK: The package must be licensed with a Fedora approved license and meet the
    Licensing Guidelines.

OK: The License field in the package spec file must match the actual license.

NA: If (and only if) the source package includes the text of the license(s) in
    its own file, then that file, containing the text of the license(s) for the
    package must be included in %doc.[4]

OK: The spec file must be written in American English. [5]

OK: The spec file for the package MUST be legible. [6]

OK: The sources used to build the package must match the upstream
    source, as provided in the spec URL.

    upstream: 94b6b61ac64c91be844aa94efe1c9247  Net-STOMP-Client-0.8.tar.gz

OK: The package MUST successfully compile and build into binary rpms on
    at least one primary architecture.

OK: If the package does not successfully compile, build or work on an
    architecture, then those architectures should be listed in the spec in
    ExcludeArch.

OK: All build dependencies must be listed in BuildRequires, except for
    any that are listed in the exceptions section of the Packaging Guidelines ;
    inclusion of those as BuildRequires is optional. Apply common sense.

NA: The spec file MUST handle locales properly. This is done by using
    the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]

NA: Every binary RPM package (or subpackage) which stores shared library
    files (not just symlinks) in any of the dynamic linker's default paths,
must
    call ldconfig in %post and %postun. [10]

OK: Packages must NOT bundle copies of system libraries.[11]

NA: If the package is designed to be relocatable, the packager must
    state this fact in the request for review

OK: A package must own all directories that it creates.

OK: A Fedora package must not list a file more than once in the spec
    file's %files listings. [14]

OK: Permissions on files must be set properly.

OK: Each package must have a %clean section, which contains rm -rf
    %{buildroot} (or $RPM_BUILD_ROOT). [16]

OK: Each package must consistently use macros. [17]

OK: The package must contain code, or permissable content. [18]

NA: Large documentation files must go in a -doc subpackage.

OK: If a package includes something as %doc, it must not affect the
    runtime of the application.

NA: Header files must be in a -devel package. [20]

NA: Static libraries must be in a -static package. [21]

NA: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'

NA: If a package contains library files with a suffix, then library files
    that end in .so (without suffix) must go in a -devel package. [20]

NA: devel packages must require the base package

NA: Packages must NOT contain any .la libtool archives, these must be
    removed in the spec if they are built.[21]

NA: Packages containing GUI applications must include a %{name}.desktop

OK: Packages must not own files or directories already owned by other
    packages.

OK: At the beginning of %install, each package MUST run rm -rf
    %{buildroot} (or $RPM_BUILD_ROOT). [26]

OK: All filenames in rpm packages must be valid UTF-8. [27]


==== SHOULD ITEMS ====
OK: The reviewer should test that the package builds in mock. [30]


==== RESULT ====
APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.