[Bug 570876] Review Request: simple-scan - Simple scanning utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=570876

--- Comment #4 from Matthias Clasen <mclasen at redhat.com> 2010-03-07 19:13:47 EST ---
checklist:

package name: ok
spec file name: ok
packaging guidelines: you need to add the usual gconf schema scriptlets, and
the patch should have an upstream bug ref or something like that
license: ok
license field: ok
license file: ok
spec file language: ok
spec file legible: ok
upstream sources: ok
buildable: ok
ExcludeArch: ok, none
BuildRequires: the GConf2 BR is redundant, GConf2-devel will pull it in. Might
be nice to group the autofoo + gnome-common requires with the patch that makes
them necessary, and also add a comment to the autogen call that ties it to the
patch
locale handling: ok
shared libs: ok, none
system libs: ok
relocatable: ok
directory ownership: might want to require yelp, for /usr/share/gnome/help (and
to make help work)
duplicate files: ok
file permissions: ok
%clean: ok
macro use: ok
permissible content: yes
large docs: ok
%doc content: ok
headers: ok, none
static libs: ok, none
pc files: ok, none
shared libs: ok
devel package: ok
libtool archives: ok
gui apps: ok
duplicate ownership: ok
%install: outdated checklist item
utf8 filenames: ok


trivia: some trailing whitespace in the spec...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.