[Bug 526916] Review Request: orc - The Oil Runtime Compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526916

Nicolas Chauvet (kwizart) <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |kwizart at gmail.com
         AssignedTo|nobody at fedoraproject.org    |kwizart at gmail.com
               Flag|                            |fedora-review?

--- Comment #13 from Nicolas Chauvet (kwizart) <kwizart at gmail.com> 2010-03-08 17:22:03 EST ---
There are several problems with this package.
- The testsuite is failing
  * Most problem seems related to libtool not patched to use /usr/lib64 by
default, so it could be easier to use autoreconf -vif
  * One test is failing because of assembler code (on F-12 x86_64 AMD64)
- There is still rpath on produced binaries (at least on x86_64) by disabled
with autoreconf
- building docs produce errors. (missing BR ?)
- It's usually better to install with install -p to prevents timestamp change
for headers, doing like:
make install DESTDIR=%{buildroot} INSTALL="install -p"
- rpmlint on installed file isn't quiet:
rpmlint orc
orc.x86_64: W: undefined-non-weak-symbol /usr/lib64/liborc-0.4.so.0.0.0 floor
orc.x86_64: W: undefined-non-weak-symbol /usr/lib64/liborc-0.4.so.0.0.0 sqrtf
orc.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liborc-pixel-0.4.so.0.0.0 /lib64/libm.so.6
orc.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liborc-pixel-0.4.so.0.0.0 /lib64/librt.so.1
orc.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liborc-float-0.4.so.0.0.0 /lib64/librt.so.1
->  liborc misses -lm at link time.

- Contradiction with README:
 - Q: How big is the Orc library?

   A: Compiled with only one target (SSE), the library size is about
   86 kB uncompressed, or 30 kB compressed.  The goal is to keep the
   uncompressed size under about 100 kB.
# ls -alh /usr/lib64/liborc-0.4.so.0.0.0
-rwxr-xr-x. 1 root root 293K mars   8 23:03 /usr/lib64/liborc-0.4.so.0.0.0
 Do we know if this library grown abnormally or that was expected and the
README need to be corrected ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.