[Bug 562469] Review Request: openvas-scanner - Open Vulnerability Assessment (OpenVAS) Scanner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562469

--- Comment #11 from Xavier Bachelot <xavier at bachelot.org> 2010-03-10 20:01:40 EST ---
the cron should be tagged as %config(noreplace). Also, it would be better to
store it in /etc/cron.d/openvas-scanner, it'll then be easier to tweak the
execution time.

The reload initscript target should be made a no op, as per the guidelines.
Sorry about my previous misleading comment. See
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Required_Actions.
As already written above, prog variable could probably be changed to
openvas-scanner (and then the initscript tweaked accordingly) for nicer startup
messages.

I still find having the sysconfdir be owned by openvas-libraries strange. I'd
rather have that owned by both -client and -server.

It's not good to strip the plugins manually, it's better to have them stripped
by duringthe rpm build in order to have the symbols in the -debuginfo package.
As the files need to be installed executable to be stripped, you can remove the
exec bit in the %files section rather than in the %install section. It makes
the %files section a bit longer, but something like that should do :
%dir %{_libdir}/openvas
%dir %{_libdir}/openvas/plugins
%attr(644,-,-) %{_libdir}/openvas/plugins/*.nes
then the following lines can be removed from the %install section:
# Fix permissions on included plugins and strip binaries
chmod 644 $RPM_BUILD_ROOT%{_libdir}/openvas/plugins/*
strip $RPM_BUILD_ROOT%{_libdir}/openvas/plugins/*

This package and the client package are getting in a good shape now. A quick
comment (or more ;-)) from Huzaifa would be nice. I'll do the formal reviews
soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.