[Bug 571502] Review Request: pidgin-birthday-reminder - Birthday Reminder plugin for Pidgin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=571502

--- Comment #2 from Kalev Lember <kalev at smartlink.ee> 2010-03-11 04:25:59 EST ---
(In reply to comment #1)
Thanks for the review, William.

> * MUST: A package must own all directories that it creates. If it does not
> create a directory that it uses, then it should require a package which does
> create that directory. [13]
> 
> is "# Pidgin package doesn't own sounds/pidgin/ dir" a bug against pidgin?

No, I don't think it's pidgin's bug. That comment in the spec file is just a
reminder for myself why I had to own this directory. On pidgin's point of view,
there is no reason why pidgin should own this dir: it doesn't place any files
in there, and also it's not a standard directory where plugins would put stuff.

So right now I think it's best if pidgin-birthday-reminder owned this dir.


> * MUST: Each package must consistently use macros. [17]
> 
> changing $RPM_BUILD_ROOT to %{buildroot} for consitancy would improve
> consistency

According to [1], choosing $RPM_BUILD_ROOT vs %{buildroot} is left entirely up
to the packager. What matters is that $RPM_BUILD_ROOT should not be mixed with
%{buildroot} in one spec.

[1]
http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS


> * SHOULD: The description and summary sections in the package spec file should
> contain translations for supported Non-English languages, if available. [29]
> 
> are translations available?    

No, none are available.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.