[Bug 570017] Review Request: k4dirstat - KDE4 version of kdirstat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=570017

Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kalev at smartlink.ee
         AssignedTo|nobody at fedoraproject.org    |kalev at smartlink.ee
               Flag|                            |fedora-review?

--- Comment #2 from Kalev Lember <kalev at smartlink.ee> 2010-03-11 05:39:05 EST ---
Taking for review.

Build for current rawhide fails with the following error:
/usr/bin/ld: CMakeFiles/k4dirstat.dir/kdirtreecache.o: undefined reference to
symbol 'gzclose'
/usr/bin/ld: note: 'gzclose' is defined in DSO /lib/libz.so.1 so try adding it
to the linker command line
/lib/libz.so.1: could not read symbols: Invalid operation
collect2: ld returned 1 exit status

This is caused by a change in the default linker behaviour, see
http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking for details.


You might want to use globs in %files section to make the package easier to
maintain. It's entirely up to you, tough, if you want to use globs in there.
For example,
%{_kde4_iconsdir}/hicolor/16x16/apps/k4dirstat.png
%{_kde4_iconsdir}/hicolor/32x32/apps/k4dirstat.png
%{_kde4_iconsdir}/hicolor/48x48/apps/k4dirstat.png

could be replaced by:
%{_kde4_iconsdir}/hicolor/*/apps/k4dirstat.png

and
%{_kde4_docdir}/HTML/en/k4dirstat/common
%{_kde4_docdir}/HTML/en/k4dirstat/index.cache.bz2
%{_kde4_docdir}/HTML/en/k4dirstat/index.docbook

could be replaced by:
%{_kde4_docdir}/HTML/en/k4dirstat/*


Fix %changelog: don't use %{?dist} macro in there, specify your name and use a
valid email address.
* Tue Mar  2 2010  <Laurent.Rineau__fedora at normale> -
0-0.2.20100223gitd3b530af3%{?dist}
should be changed to:
* Tue Mar  2 2010 Laurent Rineau <laurent.rineau__fedora at normalesup.org> -
0-0.2.20100223gitd3b530af3


Use %global instead of %define as per
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define


> Source0:        %{name}-%{preversion}.tar.gz
You'll need to add a comment how to generate the git snapshot tarball. See
https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.