[Bug 567348] Review Request: dreampie - A graphical cross-platform interactive Python shell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567348

--- Comment #4 from Ionuț Arțăriși <mapleoin at lavabit.com> 2010-03-11 06:29:58 EST ---
Hi, Mads

I couldn't find a link to the upstream's devel list (I found it now, buried at
the bottom of the frontpage). If I had, I could've seen your message in time.
On the other hand I think you too should've checked bugzilla or the
fedora-package-review list earlier.

I agree with your observations, except for the license field, which should
probably look like this:

License: GPLv3+ and LGPLv3+ and BSD and ASL 2.0 and Python

if guidelines were to be followed:
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

Alternatively we could try convincing upstream to relicense some of those
files.


I was leaving the zip file issue for discussion with the reviewer. I agree that
we shouldn't keep them archived, but install them as plain files instead.

> The py2 files should be installed as plain py files, and the
py3 files moved to a py3 subpackage on the archs where it is available.
I supppose you mean Fedora releases instead of archs. 

I don't think there's any reason to create a subpackage since we can't
determine at build time if the user has python3 installed and everyone who has
python3 will probably want py3 support in dreampie. I think we can just install
these "data files" (as upstream calls them) side-by-side for Fedora releases
with python3 (>=F13). Running dreampie against either a py2 or py3 interpreter
is one of the major features of dreampie imho, so it shouldn't be in a
different subpackage.


I see you've already established a relationship with upstream, so if you want I
can leave this package for you to take ownership of.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.