[Bug 571282] Review Request: perl-CatalystX-LeakChecker - Debug memory leaks in Catalyst applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=571282

Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |steve.traylen at cern.ch
         AssignedTo|nobody at fedoraproject.org    |steve.traylen at cern.ch
               Flag|                            |fedora-review?

--- Comment #1 from Steve Traylen <steve.traylen at cern.ch> 2010-03-11 15:28:46 EST ---
Review: perl-CatalystX-LeakChecker-0.05-1.fc12.src.rpm
Date: March 11th 2010
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2047403

*  PASS: rpmlint output
  rpmlint SRPMS/perl-CatalystX-LeakChecker-0.05-1.fc14.src.rpm \
   SPECS/perl-CatalystX-LeakChecker.spec \
   RPMS/noarch/perl-CatalystX-LeakChecker-0.05-1.fc14.noarch.rpm \
   RPMS/noarch/perl-CatalystX-LeakChecker-tests-0.05-1.fc14.noarch.rpm 

perl-CatalystX-LeakChecker-tests.noarch: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

*  PASS: Named according to the Package Naming Guidelines.
*  PASS: spec file name same as  base package %{name}.
*  PASS: Packaging Guidelines.
*  PASS: Approved license in .spec file.
 GPL & Artist.
*  PASS: License on Source code.
*  PASS: Include LICENSE file or similar if it exist.
LICENSE include.
*  PASS: Written in American English.
*  PASS: Spec file legible. 
*  PASS: Included source must match upstream source.
c6227507da51072f2ef34ea164346bf3  CatalystX-LeakChecker-0.05.tar.gz
c6227507da51072f2ef34ea164346bf3  ../SOURCES/CatalystX-LeakChecker-0.05.tar.gz
*  PASS: Build on one architecture.
*  PASS: Not building on an architecture must highlighted.
is no arch.
*  PASS: Build dependencies must be listed in BuildRequires.
*  PASS: Handle locales properly. 
No locales.
*  PASS: ldconfig must be called on shared libs.
No libs
*  PASS: No bundled copies of system libraries.
*  PASS: Package must state why relocatable if relocatable.
Not relocatable.
*  PASS: A package must own all directories that it creates
* PASS:  No duplicate files in %files listings. 
* PASS:  Permissions on files must be set properly. %defattr
* PASS:  %clean section contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
* PASS:  Each package must consistently use macros.
* PASS:  The package must contain code, or permissable content.
* PASS:  Large documentation files must go in a -doc subpackage.  
No large docs.
* PASS:  %doc  must not affect the runtime of the application. 
* PASS:  Header files must be in a -devel package.
No headers.
* PASS:  Static libraries must be in a -static package.
No statics.
* PASS:  Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
* PASS:  Then library files that end in .so 
         (without suffix) must go in a -devel package. 
* PASS:  devel packages must require the exact base package
* PASS:  No .la libtool archives
* PASS:  GUI apps should have %{name}.desktop file
* PASS:  No files or directories already owned by other packages. 
* PASS:  %install must run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
* PASS:  All filenames in rpm packages must be valid UTF-8.

Just one question What is 

'%{?perl_ext_env_unset}'

on my system it is unset.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.