[Bug 530251] Review Request: gearbox - A collection of usable peer-reviewed robotics-related libraries
bugzilla at redhat.com
bugzilla at redhat.com
Fri Mar 12 01:20:58 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530251
--- Comment #16 from Rich Mattes <richmattes at gmail.com> 2010-03-11 20:20:52 EST ---
I fixed the DSO problems, corrected the Sourceforge URL, and added the missing
ice-devel dependency. I removed the superfluous java BuildRequires as well, it
isn't needed. I also got rid of the -ice subpackage, and applied the
conditionals to the cmake line as you suggested. The directory ownership of
%{_libdir} has been fixed as well. As far as rpath, it looks like the %cmake
macro in F13 no longer includes "-DCMAKE_SKIP_RPATH:BOOL=ON" which is probably
why I didn't run into that issue on my F12 machine. I added it to my list of
cmake switches in the spec file to ensure it's always included during the
build.
Spec URL: http://www.richmattes.com/rpms/gearbox/gearbox.spec
SRPM URL: http://www.richmattes.com/rpms/gearbox/gearbox-9.11-5.fc12.src.rpm
koji:
dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2048002
dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2048013
rpmlint:
$ rpmlint ../SRPMS/gearbox-9.11-5.fc12.src.rpm ../RPMS/i686/gearbox*
gearbox.spec
4 packages and 1 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list