[Bug 565830] Review Request: paktype-naskh-basic-fonts - Fonts for Arabic from PakType

bugzilla at redhat.com bugzilla at redhat.com
Fri Mar 12 10:50:21 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565830

Pravin Satpute <psatpute at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|psatpute at redhat.com         |nkumar at redhat.com
               Flag|fedora-review?              |fedora-review+

--- Comment #13 from Pravin Satpute <psatpute at redhat.com> 2010-03-12 05:50:16 EST ---
+ package builds in mock (rawhide i686).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2048458
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url 
407b095967ceecc4a342355295dd8c83  NaskhBasic-3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
combination of "GPLv2 with Font Exceptions" and "GPLVv2+ with Font Exceptions"
so "GPLv2 with Font Exceptions" is proper license
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

install -m 0644 -p PakTypeNaskhBasicFarsi.ttf PakTypeNaskhBasic.ttf
PakTypeNaskhBasicSA.ttf PakTypeNaskhBasicUrdu.ttf PakTypeNaskhBasicSindhi.ttf
$RPM_BUILD_ROOT%{_fontdir}, do check is *.ttf works for it before import.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list