[Bug 566412] Review Request: wapiti - A web application vulnerability scanner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566412

--- Comment #6 from Nikolay Ulyanitsky <lystor at lystor.org.ua> 2010-03-13 16:02:26 EST ---
> For now license issue only

We can change the license to GPLv2 and MIT and ASL 2.0.

Examples:
* maven-plugin-cobertura: ASL 2.0 and GPLv2 and GPLv2+
* jrefactory: BSD and ASL 1.1 and GPL+
* zikula-module-menutree: GPL+ and ASL 2.0


Spec.diff:
@@ -4,11 +4,11 @@

 Name:           wapiti
 Version:        2.2.1
-Release:        2%{?dist}
-Summary:        A web application vulnerability scanner
+Release:        3%{?dist}
+Summary:        Web application vulnerability scanner

 Group:          Applications/Internet
-License:        GPLv2
+License:        GPLv2 and MIT and ASL 2.0
 URL:            http://wapiti.sourceforge.net/
 Source0:       
http://downloads.sourceforge.net/project/wapiti/wapiti/wapiti-%{version}/wapiti-%{version}.tar.bz2
 #
https://sourceforge.net/tracker/?func=detail&aid=2954112&group_id=168625&atid=847490
@@ -58,17 +58,17 @@
 %patch1 -p1

 # Copy setup.py
-%{__cp} %{SOURCE1} setup.py
+cp %{SOURCE1} setup.py

-# Change files encoding to utf8
+# Change an encoding of files to UTF-8
 for f in ChangeLog_lswww; do
     iconv -f iso-8859-1 -t utf-8 $f > $f.tmp
     touch -r $f $f.tmp
-    %{__mv} $f.tmp $f
+    mv $f.tmp $f
 done

 # Use system libraries BeautifulSoup, httplib2, SocksiPy
-%{__rm} -rf src/net/BeautifulSoup.py src/net/httplib2/
+rm -rf src/net/BeautifulSoup.py src/net/httplib2/


 %build
@@ -76,42 +76,47 @@


 %install
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}
 %{__python} setup.py install -O1 --skip-build --root %{buildroot}

 # Remove the interpreter from site-packages
 find %{buildroot}%{python_sitelib} -type f -iname "*py" -exec \
-    %{__sed} -i 's/#!\/usr\/bin\/env python//' {} \;
+    sed -i 's/#!\/usr\/bin\/env python//' {} \;

 %find_lang %{name}


 %clean
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}


 %files -f %{name}.lang
 %defattr(-,root,root,-)
 %doc AUTHORS ChangeLog_Wapiti ChangeLog_lswww README TODO example.txt
-%dir %{_sysconfdir}/%{name}
-%dir %{_sysconfdir}/%{name}/attacks
-%config(noreplace) %{_sysconfdir}/%{name}/attacks/*
-%{_bindir}/%{name}
-%{_mandir}/man1/%{name}*
-%dir %{python_sitelib}/%{name}/
-%{python_sitelib}/%{name}/attack/
-%dir %{python_sitelib}/%{name}/config/
-%{python_sitelib}/%{name}/config/vulnerabilities/
-%{python_sitelib}/%{name}/file/
-%{python_sitelib}/%{name}/language/
-%{python_sitelib}/%{name}/net/
-%{python_sitelib}/%{name}/report/
-%{python_sitelib}/%{name}/report_template/
-%{python_sitelib}/%{name}/vulnerability.py*
-%{python_sitelib}/%{name}-*.egg-info
+%dir %{_sysconfdir}/wapiti
+%dir %{_sysconfdir}/wapiti/attacks
+%config(noreplace) %{_sysconfdir}/wapiti/attacks/*
+%{_bindir}/wapiti
+%{_mandir}/man1/wapiti*
+%dir %{python_sitelib}/wapiti/
+%{python_sitelib}/wapiti/attack/
+%dir %{python_sitelib}/wapiti/config/
+%{python_sitelib}/wapiti/config/vulnerabilities/
+%{python_sitelib}/wapiti/file/
+%{python_sitelib}/wapiti/language/
+%{python_sitelib}/wapiti/net/
+%{python_sitelib}/wapiti/report/
+%{python_sitelib}/wapiti/report_template/
+%{python_sitelib}/wapiti/vulnerability.py*
+%{python_sitelib}/wapiti-*.egg-info


 %changelog
+* Sat Mar 13 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 2.2.1-3
+- Fix the license
+- Fix the summary
+- Replace generally useful macros by regular commands
+
 * Thu Mar 11 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 2.2.1-2
 - Move gettext MO files to /usr/share/locale
 - Preserve timestamps on documentation files


Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/wapiti.spec
SRPM URL: http://repo.lystor.org.ua/fedora/12/SRPMS/wapiti-2.2.1-3.fc12.src.rpm

The srpm builds successfully by the mock on Fedora 11, 12, 13 with i386/x86_64
architectures.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.