[Bug 573225] Review Request: perl-Sub-Prototype - Allows you to set a subs prototype

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573225

--- Comment #5 from Chris Weyl <cweyl at alumni.drew.edu> 2010-03-14 00:37:35 EST ---
Looks good!

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2051334

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
71e7f48e8553c3b760f0076619df74290dea036f Sub-Prototype-0.02.tar.gz
71e7f48e8553c3b760f0076619df74290dea036f Sub-Prototype-0.02.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Sub-Prototype-0.02-2.fc13.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Sub-Prototype-0.02-2.fc13.src.rpm
====> requires for perl-Sub-Prototype-0.02-2.fc13.src.rpm
perl  
perl(ExtUtils::MakeMaker)  
perl(Sub::Exporter)  
perl(Test::More)  

=====> perl-Sub-Prototype-0.02-2.fc13.x86_64.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Sub-Prototype-0.02-2.fc13.x86_64.rpm
perl(Sub::Prototype) = 0.02
perl-Sub-Prototype = 0.02-2.fc13
perl-Sub-Prototype(x86-64) = 0.02-2.fc13
====> requires for perl-Sub-Prototype-0.02-2.fc13.x86_64.rpm
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
perl >= 0:5.008001
perl(:MODULE_COMPAT_5.10.1)  
perl(strict)  
perl(Sub::Exporter)  
perl(warnings)  
perl(XSLoader)  
rtld(GNU_HASH)  

=====> perl-Sub-Prototype-debuginfo-0.02-2.fc13.x86_64.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Sub-Prototype-debuginfo-0.02-2.fc13.x86_64.rpm
perl-Sub-Prototype-debuginfo = 0.02-2.fc13
perl-Sub-Prototype-debuginfo(x86-64) = 0.02-2.fc13
====> requires for perl-Sub-Prototype-debuginfo-0.02-2.fc13.x86_64.rpm

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.