[Bug 523715] Review Request: logiweb - a system for electronic distribution of mathematics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523715

--- Comment #45 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-03-15 14:03:28 EDT ---
Okay, now 0.2.8-2 compiles at least on
- F-13 i686/x86_64
- F-12 i686/x86_64/ppc
- F-11 i586/x86_64/ppc

Some notes:

* ExclusiveArch
  - As currently clisp is not available on ppc64, you
    should add
-----------------------------------------------------------------
ExclusiveArch: %{ix86} x86_64 ppc
-----------------------------------------------------------------
    or
-----------------------------------------------------------------
ExcludeArch:  ppc64
-----------------------------------------------------------------
    ! The latter form does not exclude s390, sparc or so.
      The former form limits the supported architecure to
      %{ix86} x86_64 and ppc.

? src/lgc
  - Well, what does the "string" on line 3 mean? Is this an arbitrary
    string or is this string generated by some other process?
  ! This string seem to appear on
    * ./src/lgc
    * ./src/lgc.lgs
    * ./src/boot/lgc/lgc.lgs
  - Some other files (like ./src/testsuite/auto/autobase1.lgs or so)
    also has some seemingly-random string. Would you explain how
    these strings are generated?

? Requires
  - I don't know this software well, however is "texlive-latex, dvipdfm"
    needed for "Requires"? (from your comment 23, these don't seem
    to be needed for Requires)

! rpmlint
------------------------------------------------------------------------
logiweb.i686: W: spurious-executable-perm
/usr/share/doc/logiweb/examples/compile.sh
logiweb.i686: W: doc-file-dependency /usr/share/doc/logiweb/examples/compile.sh
/bin/bash
------------------------------------------------------------------------
  - rpmbuild automatically checks shebang related dependency for installed
    files when the files have executable permission.
    For this package as compile.sh has executable permission its shebang
dependency
    "/bin/bash" is automatically added to the rebuilt binary, which is perhaps
    not needed.

    You can supress these warnings by removing executable permission from
compile.sh
    (i.e. chmod to 0644)

* Directory ownership issue
 
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
  https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
  - Currently the following directories themselves are not owned
    by any packages.
----------------------------------------------------------------
%{_docdir}/%{name}/
----------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.